-
Notifications
You must be signed in to change notification settings - Fork 7
Adds topic required form fields to the Web forms section #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
"Both are fine, as long as you are consistent within the form and if possible also withing all forms on your website." Change "withing" to "within". |
|
@GaryJones, @michaelhastrich, @jaapwiering |
|
@joedolson can you have a read too? |
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some misc. changes.
…60-indicate-required-fields-in-forms
|
@joedolson @GaryJones I made most of the changes you suggested. The text about the pros and cons of HTML5 validation will be addressed in the section about feedback on forms later. I also added descriptions, hopefully to be used in the search page results later. Can you have a final look and if you agree merge? |
# Conflicts: # docs/topics/forms/required.md
47c8400
Related issue: #160
Preview: https://wpaccessibility.org/pr-preview/pr-210/docs/topics/forms/required/.
The page required is now a section with 4 pages: