Skip to content

Conversation

@rianrietveld
Copy link
Member

@rianrietveld rianrietveld commented Oct 27, 2025

Related issue: #160
Preview: https://wpaccessibility.org/pr-preview/pr-210/docs/topics/forms/required/.

The page required is now a section with 4 pages:

  • Intro page Indicate required fields in forms
  • Mark required fields
  • Mark non-required fields
  • Mark required for screen readers

@rianrietveld rianrietveld self-assigned this Oct 27, 2025
@rianrietveld rianrietveld moved this to PRs to review in WP A11y docs Oct 27, 2025
@rianrietveld rianrietveld linked an issue Oct 27, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

PR Preview
Preview removed because the pull request was closed.
2025-11-14 05:43 UTC

@jaapwiering
Copy link

"Both are fine, as long as you are consistent within the form and if possible also withing all forms on your website." Change "withing" to "within".

@rianrietveld
Copy link
Member Author

@GaryJones, @michaelhastrich, @jaapwiering
Thanks for the feedback, I made the suggested changes.

@rianrietveld
Copy link
Member Author

@joedolson can you have a read too?

Copy link
Member

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some misc. changes.

@rianrietveld
Copy link
Member Author

rianrietveld commented Nov 12, 2025

@joedolson @GaryJones I made most of the changes you suggested. The text about the pros and cons of HTML5 validation will be addressed in the section about feedback on forms later.

I also added descriptions, hopefully to be used in the search page results later.

Can you have a final look and if you agree merge?

joedolson
joedolson previously approved these changes Nov 13, 2025
GaryJones
GaryJones previously approved these changes Nov 13, 2025
# Conflicts:
#	docs/topics/forms/required.md
@rianrietveld rianrietveld dismissed stale reviews from GaryJones and joedolson via 47c8400 November 14, 2025 05:36
@rianrietveld rianrietveld merged commit c975f59 into main Nov 14, 2025
2 checks passed
@rianrietveld rianrietveld deleted the 160-indicate-required-fields-in-forms branch November 14, 2025 05:43
@github-project-automation github-project-automation bot moved this from PRs to review to Done in WP A11y docs Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Topic] Indicate required fields in forms

5 participants