Adds docs about fieldsets in forms #217
Conversation
|
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
I have some quarrel with stating that fieldset/legend are required for WCAG; I'd argue that they're the preferred technique, but not the sole way to meet this criteria.
I changed the text into "WCAG Success Criteria for naming grouped form fields" and added an ARIA example with the comment (not preferred). I made all the changes, thank you for the review. |
# Conflicts: # docs/topics/forms/descriptions/content-description.md # docs/topics/forms/descriptions/decision-tree-description.md # docs/topics/forms/fieldsets.md
GaryJones
left a comment
GaryJones
left a comment
There was a problem hiding this comment.
Few little tweaks needed I think, but ✅
Co-authored-by: Gary Jones <[email protected]>
|
Thanks @GaryJones for the review, I made the changes you suggested. Can you please approve and merge if you agree? |
|
@rianrietveld One more set of value attributes needed in |
|
Thanks @GaryJones I hope I've got everything now :-) |
The related issue number: #157
Preview: https://wpaccessibility.org/pr-preview/pr-217/docs/topics/forms/fieldsets/
Adds content about fieldsets, legends and description s with a fieldset in forms.
I moved info about the descriptions from the section about input/label to this section as that made more sense. I added a reference and a link on the input/label - description page to the new location.
This needs a demo with a video, I will do that when I figured out how to make screen videos with NVDA on Windows.