Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Dec 20, 2024

Added page title to the docs pages from the metadata exported in the mdx file.

image

@colinmurphy colinmurphy self-assigned this Dec 20, 2024
@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-feature-add-titles-page-templates https://ht…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@colinmurphy colinmurphy added the enhancement New feature or request label Dec 20, 2024
@colinmurphy
Copy link
Member Author

@moonmeister Can you review the code and see if there is anything wrong with this approach please.

@colinmurphy colinmurphy changed the title Added component to load the title from the metadata Set docs page title from metadata set in the MDX file Dec 20, 2024
@colinmurphy colinmurphy changed the title Set docs page title from metadata set in the MDX file Feature; Set docs page title from metadata set in the MDX file Dec 20, 2024
@colinmurphy colinmurphy changed the title Feature; Set docs page title from metadata set in the MDX file Feature: Set docs page title from metadata set in the MDX file Dec 20, 2024
@colinmurphy colinmurphy marked this pull request as ready for review December 20, 2024 11:27
@Fran-A-Dev
Copy link
Contributor

Niceeee @colinmurphy thanks for doing this!

@colinmurphy
Copy link
Member Author

No worries at all @Fran-A-Dev 😁

Copy link
Contributor

@Fran-A-Dev Fran-A-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pulled it down and tested it locally on the browser. The titles look great.

@colinmurphy
Copy link
Member Author

Thanks @Fran-A-Dev for testing

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-feature-add-titles-page-templates https://ht…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister moonmeister merged commit bd77057 into toolkit Dec 30, 2024
3 of 4 checks passed
@moonmeister moonmeister deleted the feature-add-titles-page-templates branch December 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: ✅ Closed

Development

Successfully merging this pull request may close these issues.

4 participants