Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jan 2, 2025

See #213

Fixes the following issues

  • Added breadcrumbs to the doc pages
  • Added previous/next links to the doc pages
  • No active state for the docs menu for the current page
  • Fixes mobile layout issues with the doc pages e.g. /docs/how-to/authentication/ was overflowing horizontally
  • Fixed some 404s on a docs page
  • Various mobile menu fixes around z-index and also search index issues
  • Fixed issue when you opened the main mobile menu and you were scrolled down the page it didn't appear
  • Fixed issue with search appearing behind docs menu bar on mobile
  • Fixed issue when trying to scroll down the mobile nav bar and scrolling the page instead

@colinmurphy colinmurphy changed the title Bug fix mobile desktop issues bug: fix mobile desktop issues Jan 2, 2025
@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@colinmurphy
Copy link
Member Author

@moonmeister @Fran-A-Dev @kellenmace Happy New Year :)

I am working through some issues from #213 and I still have a few more to fix but this is where I am at currently.
Most of this work relates to the mobile menu issues.

I will let you know once this is ready.

@colinmurphy
Copy link
Member Author

Added prev/next docs links
image

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@colinmurphy
Copy link
Member Author

Adding breadcrumbs for the docs navigation

Screenshot 2025-01-03 at 14 59 41

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

Adding breadcrumbs for the docs navigation

Screenshot 2025-01-03 at 14 59 41

I love this, let's have it say "Docs" instead of "Getting Started"

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

moonmeister commented Jan 3, 2025

Added prev/next docs links
image

🤔 I like the feature for a tutorial. But for other docs that aren't sequential it feels a little misleading.

To be fair the " next steps" section of that doc shown is also misleading and should be removed.

@kellenmace or @Fran-A-Dev thoughts, I could go either way?

@colinmurphy colinmurphy marked this pull request as ready for review January 3, 2025 15:47
@colinmurphy
Copy link
Member Author

@moonmeister @Fran-A-Dev @kellenmace This PR is ready for review. I updated the description of the PR with the list of changes/fixes.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-mobile-desktop-issues https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister moonmeister merged commit 1e34850 into toolkit Jan 6, 2025
4 checks passed
@moonmeister moonmeister deleted the bug-fix-mobile-desktop-issues branch January 6, 2025 22:40
@moonmeister
Copy link
Member

Thanks, @colinmurphy. I'm merging this. If you could update #213 with what's been resolved here that'd be great. Feel free to knock anything else off that list.

@colinmurphy
Copy link
Member Author

Thanks @moonmeister

I will have a look today. I will update what is completed and also create a new PR of any outstanding issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Closed

Development

Successfully merging this pull request may close these issues.

3 participants