-
Notifications
You must be signed in to change notification settings - Fork 3
Fix: Added Tip to Sitemap Doc #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
LGTM 🎉 Thanks @Fran-A-Dev 😄 |
|
|
||
|  | ||
|
|
||
| > [!TIP] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would a user want to do this? Is this a step they should do or something they do only if they see other errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a must- do. The the sitemap path breaks and 404's if that box is checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callouts are generally for accessory information. TIPs, in particular, should be read as optional. This sounds like it should be its own step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I'll change it to its own step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moonmeister this is good to merge now, committed and pushed the change
|
@Fran-A-Dev I'm not seeing that change yet, did you forget to push code? |
Oh word, I thought I pushed it. I think I just committed it locally. Let me push |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
I added a tip to users when reading it to check their WP sitemap domain.