-
Notifications
You must be signed in to change notification settings - Fork 3
docs: Update sitemaps docs for other wp plugins #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update sitemaps docs for other wp plugins #251
Conversation
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
|
||
| Run the dev server again and visit the sitemap URL. You now have WordPress content and Next.js content in your Faust app. | ||
|
|
||
| ## 4. Changing the sitemap URL for other WordPress SEO plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this section header to fit the page better with the link icon to this :
## 4. Changing the sitemap URL for other WP SEO plugins
|
|
||
| ## 4. Changing the sitemap URL for other WordPress SEO plugins | ||
|
|
||
| If you wanted to use a different sitemap than the one that comes out of the box with WordPress this is possible with Faust for other WordPress SEO plugins like Rank Math or Yoast SEO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| If you wanted to use a different sitemap than the one that comes out of the box with WordPress this is possible with Faust for other WordPress SEO plugins like Rank Math or Yoast SEO. | ||
|
|
||
| You just need to update the argument for `sitemapIndexPath` to point to the plugins sitemap URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing this sentence to this:
"Simply update the sitemapIndexPath argument to point to the plugin's sitemap URL."
|
|
||
| You just need to update the argument for `sitemapIndexPath` to point to the plugins sitemap URL. | ||
|
|
||
| e.g. for Rank Math: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to the sentence below to this:
"Here is an example for the Rank Math plugin:"
|
|
||
| e.g. for Rank Math: | ||
|
|
||
| ```js title="pages/sitemap.xml.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlight the arg that you want the reader to focus on:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colinmurphy I don't know why GH is not showing the line of MDX but this is what I am suggesting:
js {6} title="pages/sitemap.xml.js"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Fran-A-Dev
That i s a really good tip. I never knew you could do that so thank you 😄
|
Thanks @Fran-A-Dev for the review 😄 I will look at updating the PR now. I really appreciate the good feedback 👍 |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
Fran-A-Dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Included an example pf how to integrate Rank Math with Faust.
For reference see the original PR here in Faust - wpengine/faustjs#1936