Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Feb 19, 2025

  • Docs layout moved from mdx-components.jsx to _app to prevent unmounting. Unmounting causes navBar to jump up on page change
  • Low color contrast issues fixed
  • Skip links added above header and to docs navbar
  • HTML title added to single WP pages and 404 page
  • Accessible names added to some doc links
  • Authentication page in docs reordered in navBar

Screenshot 2025-02-19 at 18 20 13
Screenshot 2025-02-19 at 18 20 20

@ahuseyn ahuseyn requested a review from moonmeister February 19, 2025 17:26
@ahuseyn ahuseyn mentioned this pull request Feb 19, 2025
@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

moonmeister commented Feb 19, 2025

THese are my docs:
image

Update: guessing your docs layout detection isn't working. I'd switch that to router-based. I'm guessing the componenet name gets minified in prod

Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, couple things I couldn't check due to late issues but I expect this to be good once we get that taken care of

a11yreview1.mp4

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

@ahuseyn Hmm, I'm still seeing those twitches as recorded in my video. Is that what the docs layout move was supposed to fix? Or is this a sperate issue? Also, please resolve your merge conflict

@ahuseyn
Copy link
Member Author

ahuseyn commented Feb 20, 2025

@ahuseyn Hmm, I'm still seeing those twitches as recorded in my video. Is that what the docs layout move was supposed to fix? Or is this a sperate issue? Also, please resolve your merge conflict

@moonmeister It must be a separate issue, which I can take a look at as well.

The layout fix in this PR intends to prevent docs sidebar unmounting on each page change. As you can see in the video, when this happens, docs scrollbar jumps up to the starting position.

Screen.Recording.2025-02-20.at.09.55.52.mov

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-toolkit-accessibility-fixes https://ho…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@ahuseyn ahuseyn requested a review from moonmeister February 20, 2025 13:10
@moonmeister moonmeister merged commit b8fadbd into toolkit Feb 20, 2025
4 checks passed
@moonmeister moonmeister deleted the toolkit-accessibility-fixes branch February 20, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants