Enhancement: Github edit link for the docs pages #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmurphy
requested review from
Fran-A-Dev,
ahuseyn,
kellenmace and
moonmeister
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
ahuseyn
previously approved these changes
Feb 21, 2025
Member
ahuseyn
left a comment
ahuseyn
left a comment
There was a problem hiding this comment.
This is a nice update! Thanks @colinmurphy.
Member
Author
Thanks @ahuseyn 😄 |
Fran-A-Dev
requested changes
Feb 21, 2025
src/components/docs-layout.jsx
Outdated
| href={`https://github.com/wpengine/faustjs.org/edit/main/src/pages${asPath}index.mdx`} | ||
| noDefaultStyles | ||
| > | ||
| Edit this doc on GitHub |
Contributor
There was a problem hiding this comment.
@colinmurphy What do you think about this phrase:
"Improve & Edit this doc on GitHub"
Member
Author
There was a problem hiding this comment.
@Fran-A-Dev I really like that suggestion 😄
Let me get a update for the PR.
Member
Author
There was a problem hiding this comment.
Pushed a change for this 😄
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a link to edit the docs page on Github now that the project is public.
Please review and also the wording. I changed my mind a few times on what it should say.
Another thing to note is as the right hand sidebar isn't visible on mobile, neither is this link.
Solves #285