Skip to content

fix: mobile nav issues #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moonmeister merged 5 commits into from
Mar 7, 2025
Merged

fix: mobile nav issues #310

moonmeister merged 5 commits into from
Mar 7, 2025

Conversation

@moonmeister
Copy link
Member

@moonmeister moonmeister commented Mar 4, 2025 •
edited
Loading

image

@moonmeister moonmeister marked this pull request as draft March 4, 2025 23:08
@headless-platform-by-wp-engine
Copy link

headless-platform-by-wp-engine bot commented Mar 4, 2025

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix-mobile-nav https://hc…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine
Copy link

headless-platform-by-wp-engine bot commented Mar 5, 2025

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix-mobile-nav https://hc…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@Fran-A-Dev Fran-A-Dev requested a review from kellenmace March 5, 2025 20:35
Fran-A-Dev
Fran-A-Dev previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Fran-A-Dev Fran-A-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonmeister
Copy link
Member Author

moonmeister commented Mar 5, 2025 •
edited
Loading

Just tested on my phone and it broke :/

@Fran-A-Dev
Copy link
Contributor

Fran-A-Dev commented Mar 5, 2025

Just tested on my phone and it broke :/

@Fran-A-Dev Fran-A-Dev closed this Mar 5, 2025
@Fran-A-Dev
Copy link
Contributor

Fran-A-Dev commented Mar 5, 2025

Sorry accidentally closed this.

@Fran-A-Dev Fran-A-Dev reopened this Mar 5, 2025
@headless-platform-by-wp-engine
Copy link

headless-platform-by-wp-engine bot commented Mar 5, 2025

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix-mobile-nav https://h8…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@Fran-A-Dev
Copy link
Contributor

Fran-A-Dev commented Mar 5, 2025

Just tested on my phone and it broke :/

Kellen and I were tested this today. I did notice, maybe you did not push up the change of the Popover component. I could not find it anywhere.

Just tested on my phone and it broke :/

@moonmeister
Copy link
Member Author

moonmeister commented Mar 6, 2025

Just tested on my phone and it broke :/

Kellen and I were tested this today. I did notice, maybe you did not push up the change of the Popover component. I could not find it anywhere.

Just tested on my phone and it broke :/

Seems that's the issue. My laptop is not near me. I'll take care of it Friday or Monday. Thanks all.

@headless-platform-by-wp-engine
Copy link

headless-platform-by-wp-engine bot commented Mar 6, 2025

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix-mobile-nav https://h8…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

Fran-A-Dev
Fran-A-Dev previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@Fran-A-Dev Fran-A-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonmeister moonmeister marked this pull request as ready for review March 7, 2025 02:37
@moonmeister moonmeister enabled auto-merge March 7, 2025 02:37
@moonmeister moonmeister requested a review from Fran-A-Dev March 7, 2025 02:38
@headless-platform-by-wp-engine
Copy link

headless-platform-by-wp-engine bot commented Mar 7, 2025

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix-mobile-nav https://h8…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

Fran-A-Dev
Fran-A-Dev approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@Fran-A-Dev Fran-A-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonmeister moonmeister merged commit 9fe820c into main Mar 7, 2025
4 checks passed
@moonmeister moonmeister deleted the fix-mobile-nav branch March 7, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fran-A-Dev Fran-A-Dev Fran-A-Dev approved these changes

@kellenmace kellenmace Awaiting requested review from kellenmace

Assignees

@Fran-A-Dev Fran-A-Dev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moonmeister @Fran-A-Dev @kellenmace