-
Notifications
You must be signed in to change notification settings - Fork 3
security: Update dependencies #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
moonmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-config-neon provides all of our eslint configs. Many of these are available on their own. But they do the hard work of updating those configs to support the latest version of eslint config standards.
we'd need to rebuild our eslint config if we drop neon. This is a great example of a how these security checks are completely pointless. This isn't a security concern, we're not using that part of the neon config, and it's only running in CI. Yet here we are spending way too much time dealing with it.
package.json
Outdated
| "eslint-config-prettier": "^10.1.1", | ||
| "eslint-plugin-mdx": "^3.2.0", | ||
| "eslint-plugin-svelte": "^3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did these get added?
"eslint-plugin-svelte": "^3.1.0",
"eslint-config-prettier": "^10.1.1",
This reverts commit 0c34d0d.
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
|
@josephfusco Can confirm this won't update that svelte dependency. do we want to do some kind of override or file for an exception? |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |

This PR removes
eslint-config-neonwhich contained a transitive dependency of [email protected]. This solves the corresponding dependabot alert:https://github.com/wpengine/faustjs.org/security/dependabot/33
These changes also bring outdated dependencies up to date with their latest versions.
I am not sure what
eslint-config-neonwas doing, however some tests are failing.