Skip to content

Conversation

@josephfusco
Copy link
Member

@josephfusco josephfusco commented Mar 14, 2025

This PR removes eslint-config-neon which contained a transitive dependency of [email protected]. This solves the corresponding dependabot alert:

https://github.com/wpengine/faustjs.org/security/dependabot/33

These changes also bring outdated dependencies up to date with their latest versions.

I am not sure what eslint-config-neon was doing, however some tests are failing.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

only all of our linting.
image

Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-config-neon provides all of our eslint configs. Many of these are available on their own. But they do the hard work of updating those configs to support the latest version of eslint config standards.

we'd need to rebuild our eslint config if we drop neon. This is a great example of a how these security checks are completely pointless. This isn't a security concern, we're not using that part of the neon config, and it's only running in CI. Yet here we are spending way too much time dealing with it.

package.json Outdated
Comment on lines 56 to 58
"eslint-config-prettier": "^10.1.1",
"eslint-plugin-mdx": "^3.2.0",
"eslint-plugin-svelte": "^3.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these get added?

"eslint-plugin-svelte": "^3.1.0",
"eslint-config-prettier": "^10.1.1",

@josephfusco josephfusco self-assigned this Mar 17, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Headless OSS Mar 17, 2025
@josephfusco josephfusco moved this from 🆕 Backlog to 🏗 In progress in Headless OSS Mar 17, 2025
@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@josephfusco josephfusco moved this from 🏗 In progress to 👀 In review in Headless OSS Mar 19, 2025
@moonmeister moonmeister enabled auto-merge March 19, 2025 19:15
@moonmeister moonmeister disabled auto-merge March 19, 2025 19:15
@moonmeister
Copy link
Member

@josephfusco Can confirm this won't update that svelte dependency. do we want to do some kind of override or file for an exception?

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-dependabot-svelte https://hy…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister moonmeister merged commit 590a16d into main Mar 19, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Closed in Headless OSS Mar 19, 2025
@moonmeister moonmeister deleted the dependabot-svelte branch March 19, 2025 20:44
@moonmeister
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Closed

Development

Successfully merging this pull request may close these issues.

3 participants