-
Notifications
You must be signed in to change notification settings - Fork 3
Chore fix canonicals remove queries #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <[email protected]>
…gine/faustjs.org into chore-fix-canonicals-remove-queries
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
moonmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue isn't the URL has a query param. The issue is the source of the URL should never be the next router. Right?
Do we have the url of the page for the markdown? even if we do have to use the router we can use pathname instead of string splitting on '?'.
I disagree with all the changes in SEO.jsx. It should error if no url is passed among other things.
|
I'm reverting seo.jsx. I am not sure what do you mean by "source of the URL should never be in the next router". In docs page, we have I used the router.query params approach - let me know what do you think. |
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
Fran-A-Dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In docs-layout.jsx we will format the url and send it correctly to seo.jsx.
In seo.jsx we will just cover cases where we "forgot" to format it prior passing it.
Perhaps, it is an overkill for check twice and format it but safety first. Let me know what do you think.