Chore: misc fixes, cleanup, & updates #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up code and resolves issues in local development while refactoring the way possible types are handled by dynamically generating them. Key changes include:
- Removing the export of DOCS_PATH in favor of using repo constants.
- Removing the committed possibleTypes.json file to rely on generated types.
- Updating various dependency versions and scripts (including search and Tailwind) in package.json.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/remote-mdx-files.mjs | Removed DOCS_PATH export; now using internal constant for nav JSON path construction |
| possibleTypes.json | Deleted file; switching to generating possible types dynamically |
| package.json | Updated scripts and dependency versions to support new workflows and fixes |
| next.config.mjs | Adjusted DOCS_PATH usage by importing repo constants and recomputing GitHub raw URL paths |
Comments suppressed due to low confidence (2)
possibleTypes.json:1
- [nitpick] The deletion of possibleTypes.json in favor of dynamically generated types is acceptable. Ensure that the generatePossibleTypes script is adequately covered by tests to catch any omissions.
Removed possibleTypes.json content
src/lib/remote-mdx-files.mjs:23
- Removal of the export from DOCS_PATH appears intentional as next.config.mjs now sources these values from constants. Please confirm that DOCS_PATH is not used externally anywhere else.
const DOCS_PATH = `https://raw.githubusercontent.com/${DOCS_OWNER}/${DOCS_REPO}/refs/heads/${DOCS_BRANCH}/${DOCS_FOLDER}`;
|
Check out the recent updates to your Headless Platform preview environment:
Learn more about preview environments in our documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebuildandpredevscripts as opposed to committing to the repo and being out-of-date constantly.