Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Dec 19, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Updates nanoid to version 3.3.8 for security. See nanoid changelog for reference "Fixed a way to break Nano ID by passing non-integer"

Related Issue(s):

#2010

Testing

Tested example block support branch locally with WordPress 6.7.1 using FaustWP and WPGraphQL using Local.

Screenshots

image image

Documentation Changes

Dependant PRs

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 4866c0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@josephfusco josephfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@colinmurphy colinmurphy merged commit 836009b into canary Dec 20, 2024
18 checks passed
@colinmurphy colinmurphy deleted the security-update-nanoid-3.3.8 branch December 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants