Feature to add anchor attribute to core/paragraph block#2015
Feature to add anchor attribute to core/paragraph block#2015theodesp merged 3 commits intowpengine:canaryfrom
Conversation
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: dd4b945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thanks @jan-clockworkwp |
packages/blocks/package.json
Outdated
| { | ||
| "name": "@faustwp/blocks", | ||
| "version": "5.0.0", | ||
| "version": "5.1.0", |
There was a problem hiding this comment.
This should be a patch version instead. We are not breaking anything.
There was a problem hiding this comment.
Hi @theodesp, I was just trying to follow semver that, if I understand correctly, patch bumps are meant for backwards-compatible bug fixes, and minor bumps are for backwards-compatible new feature releases. I naturally considered this a new feature as it was adding functionality, but it could have been considered a fix as well. Do you want me to change it to version 5.0.1 instead?
There was a problem hiding this comment.
Hey @jan-clockworkwp .I thin with a major change it should be 6.0.0 since we change the schema. We should update the changeset document to mention the nature of the change though.
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
Tasks
@faustjs/blockspackage on canary branch by thechangesetpackage was4.0.1but in the code was version5.0.0, so that is the reason why my changeset entry is marked as major change.Description
As mentioned in the following feature request, an anchor attribute was added in the
@faustjs/blockspackage and theCoreParagraphblock.Related Issue(s):
[feat] Add anchor attribute to core/paragraph block #1954
Testing
idtag of HTML anchor value.npm run testfrom the@faustjs/blockspackage root to run all blocks code testsNote: This feature is needed only for the templates where the content is being rendered with the
WordPressBlocksViewercomponent.Screenshots
Documentation Changes
Dependant PRs