Skip to content

Conversation

@moonmeister
Copy link
Member

@moonmeister moonmeister commented Feb 17, 2025

Description

Update prettier config to align with the incoming website.

  • Added missing code formatting to @faustwp/block-editor-utils
  • Remove duplicate configs from .prettierrc.js that already exist in .editorconfig (prettier will use the latter when present)
  • Convert to tabs
  • Set up eslint + prettier integration correctly (This has the side effect of not running prettier inside eslint, and thus formatting checks are no longer being run on GH Actions. This will be addressed in a separate PR)

Tabs offer significant benefits over spaces. If you don't like size 4 tabs (as I don't) you can change your edits tab sizing defaults, though the editor config is set to display with size 2 by default.
https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig - this will have VS code honor the .editorconfig file.
image - to customize tab sizing

Does anyone have any questions or concerns?

@moonmeister moonmeister requested a review from a team as a code owner February 17, 2025 19:38
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: b3e2452

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@faustwp/block-editor-utils Patch
@faustwp/core Patch
@faustwp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 260.26 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@colinmurphy
Copy link
Member

@moonmeister LGTM

I will do some testing locally tomorrow with this PR.

@colinmurphy
Copy link
Member

@moonmeister Tested locally and all seems good to me 👍

@moonmeister moonmeister merged commit 74e55bc into canary Feb 18, 2025
17 checks passed
@moonmeister moonmeister deleted the prettier-rework branch February 18, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Closed

Development

Successfully merging this pull request may close these issues.

4 participants