Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Feb 20, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This solves #2030

This creates an additional release for FaustWP without the external WPE updater.

Related Issue(s):

#2030

Testing

I had created a test action which just outputted the content. Commit here d4a88b6

See attached screenshots from test run which outputted the zip files correctly

Screenshot 2025-02-20 at 15 26 18 Screenshot 2025-02-20 at 15 26 26

I also wrote a test bash script off the second action to test it locally

@ -0,0 +1,26 @@
#!/bin/bash

# Set environment variables
PLUGIN_DIR="$(pwd)/plugins/faustwp"
SLUG="faustwp"
VERSION="4.8.1"


# Delete old directory
rm -rf dist

# Create dist folder and copy files while excluding .distignore items
mkdir -p dist

# Copy plugin files to dist folder and exclude external updater
rsync -av --exclude-from="${PLUGIN_DIR}/.distignore" --exclude="includes/updates/check-for-updates.php" --exclude="includes/updates/class-plugin-updater.php" "${PLUGIN_DIR}/" "dist/${SLUG}"

# Updates for the CHANGELOG file

sed -i '' -e 's/plugin updates from an external API endpoint./plugin updates from an external API endpoint when not installed from WordPress.org/' dist/faustwp/CHANGELOG.md

# Create .org zip file
org_zip_file="faustwp-${VERSION}.org.zip"
zip -r "$org_zip_file" "dist/${SLUG}"

echo "Zip file created at: $PWD/$org_zip_file"

I have uploaded and tested this file on

PHP 8.2
WordPress 6.7

Screenshots

Documentation Changes

Dependant PRs

…st action to create the zips and check the file content.
When creating a release for FaustWP we will create 2 zip files and it will contain a zip with and without the external WPE update service.
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: e1f9c01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@colinmurphy colinmurphy marked this pull request as ready for review February 20, 2025 16:46
@colinmurphy colinmurphy requested a review from a team as a code owner February 20, 2025 16:46
Github workflow failing as we could not download the zip. Numerous re-tries through out the day.
@colinmurphy colinmurphy requested a review from theodesp February 24, 2025 10:24
@colinmurphy colinmurphy merged commit 9dc634e into canary Feb 24, 2025
18 checks passed
@colinmurphy colinmurphy deleted the chore-update-faustwp-release-process branch February 24, 2025 12:20
@colinmurphy colinmurphy restored the chore-update-faustwp-release-process branch February 24, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants