docs: add contributing guide #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuseyn
requested review from
josephfusco,
moonmeister,
theodesp and
whoami-pwd
moonmeister
requested changes
Mar 26, 2025
Member
moonmeister
left a comment
moonmeister
left a comment
There was a problem hiding this comment.
Looks good! A couple layout and logistical things. Have we added changesets to this repo? Should we?
moonmeister
reviewed
Mar 26, 2025
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Member
Author
|
Thanks @moonmeister, I've committed your suggestions except the email issue. I don't think we have changeset in this repo. We can discuss pros/const at this stage with the @wpengine/headless-open-source. |
moonmeister
previously approved these changes
Mar 27, 2025
colinmurphy
requested changes
Mar 27, 2025
Member
colinmurphy
left a comment
colinmurphy
left a comment
There was a problem hiding this comment.
LGTM 🚀
I have added some small suggestion to add code of conduct (not merged but awaiting on one review)
Co-authored-by: Colin Murphy <[email protected]>
moonmeister
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds contribution guide to hwptoolkit.
Related to #95
Subheadings: