Skip to content

chore: Fix PHP linting errors for previews plugin and setup automated code quality #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colinmurphy merged 20 commits into from
Jun 3, 2025
Merged

chore: Fix PHP linting errors for previews plugin and setup automated code quality #236

colinmurphy merged 20 commits into from
Jun 3, 2025

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented May 29, 2025 •
edited
Loading

Description

This fixes PHP Code Quality issues for the Previews Plugin and also adds a code quality check for PRs for a plugin.

Related Issue

Fixes #181
Fixes #214

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@github-actions
Copy link

github-actions bot commented May 29, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 29, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy
Copy link
Member Author

colinmurphy commented May 29, 2025

@ahuseyn

I wanted to say I think once this refactor is complete, lets use the new artifact to test to make sure all existing functionality is still working as we don't have e2e tests and unit tests setup.

Currently 50% through with Psalm, PHPCS complete and another 30 odd errors for PHPStan.

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy
Copy link
Member Author

colinmurphy commented May 30, 2025

Workflow is now working :)

Screenshot 2025-05-30 at 11 21 22

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy marked this pull request as ready for review May 30, 2025 14:20
@colinmurphy colinmurphy requested a review from a team as a code owner May 30, 2025 14:20
@colinmurphy colinmurphy changed the title chore: DRAFT - Fix PHP linting errors for previews plugin. chore: Fix PHP linting errors for previews plugin. Added PHP Code Quality checks for a PR. May 30, 2025
@colinmurphy
Copy link
Member Author

colinmurphy commented May 30, 2025

@wpengine/headless-open-source

Putting this back in draft as found a few issues 👍

@colinmurphy colinmurphy changed the title chore: Fix PHP linting errors for previews plugin. Added PHP Code Quality checks for a PR. chore: DRAFT - Fix PHP linting errors for previews plugin. Added PHP Code Quality checks for a PR. May 30, 2025
@colinmurphy colinmurphy marked this pull request as draft May 30, 2025 14:49
@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy changed the title chore: DRAFT - Fix PHP linting errors for previews plugin. Added PHP Code Quality checks for a PR. chore: Fix PHP linting errors for previews plugin and setup automated code quality May 30, 2025
@colinmurphy colinmurphy marked this pull request as ready for review May 30, 2025 15:25
@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@github-actions
Copy link

github-actions bot commented May 30, 2025

ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom).

@colinmurphy colinmurphy mentioned this pull request May 30, 2025
Merged
15 tasks
ahuseyn
ahuseyn approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@ahuseyn ahuseyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@colinmurphy colinmurphy added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 62995f7 Jun 3, 2025
9 checks passed
@colinmurphy colinmurphy deleted the chore-fix-php-linting-errors-previews branch June 3, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahuseyn ahuseyn ahuseyn approved these changes

@theodesp theodesp Awaiting requested review from theodesp

@josephfusco josephfusco Awaiting requested review from josephfusco

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Add linting Github action for Previews bug: Fix the linter errors

3 participants

@colinmurphy @ahuseyn