Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Jun 25, 2025

Description

This is the first iteration of the beta release process.

Note

This process should be updated once we have actual releases of plugins.

Process

  1. When a PR is merged for a plugin with a changset, this triggers the pre-release workflow

This does the following

  1. Install npm, pnpm, PHP
  2. It will bump the package.json version of the plugin based off the changeset
  3. Checks that a package.json exists with a valid name (needed for changesets)
  4. It creates a pre-release tag based off the package name and version e.g. @hwp-previews/wordpress-plugin-0.0.1-beta
  5. It will then create a zip of the plugin using composer archive
  6. Finally this will be uploaded to the GitHub tag

Related Issue

#257

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025

🦋 Changeset detected

Latest commit: 69cdb6a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy changed the title chore: DRAFT - Initial PR for Changeset plugin releases chore: Initial PR for Changeset plugin releases Jun 25, 2025
@colinmurphy colinmurphy marked this pull request as ready for review June 25, 2025 13:46
@colinmurphy colinmurphy requested a review from a team as a code owner June 25, 2025 13:46
…:wpengine/hwptoolkit into chore-setup-release-workflow-iteration-1
@colinmurphy colinmurphy enabled auto-merge June 25, 2025 15:19
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question, I believe changesets supports doing pre-release tags like "beta" or "next", would that be beneficial for us or because the versions are less than 1.0 is it pointless?

@colinmurphy
Copy link
Member Author

General question, I believe changesets supports doing pre-release tags like "beta" or "next", would that be beneficial for us or because the versions are less than 1.0 is it pointless?

Thanks @moonmeister

I wasn't aware that they did have option so I will look into it ❤️ Thanks for the feedback.

@colinmurphy colinmurphy changed the title chore: Initial PR for Changeset plugin releases chore: DRAFT Initial PR for Changeset plugin releases Jun 25, 2025
@colinmurphy colinmurphy marked this pull request as draft June 25, 2025 16:31
auto-merge was automatically disabled June 25, 2025 16:31

Pull request was converted to draft

@colinmurphy colinmurphy changed the title chore: DRAFT Initial PR for Changeset plugin releases chore: DRAFT Initial PR for creating pre-release tags for a plugin Jun 25, 2025
@colinmurphy colinmurphy changed the title chore: DRAFT Initial PR for creating pre-release tags for a plugin chore: Initial PR for creating pre-release tags for a plugin Jun 25, 2025
@colinmurphy colinmurphy marked this pull request as ready for review June 25, 2025 18:06
@colinmurphy colinmurphy requested review from a team and moonmeister June 25, 2025 18:06
@colinmurphy
Copy link
Member Author

@moonmeister

This is ready for another review. I have simplified the process as per your feedback.

Process
When a PR is merged for a plugin with a changset, this triggers the pre-release workflow
This does the following:

1. Install npm, pnpm, PHP
2. It will bump the package.json version of the plugin based off the changeset
3. Checks that a package.json exists with a valid name (needed for changesets)
4. It creates a pre-release tag based off the package name and version e.g. @hwp-previews/wordpress-plugin-0.0.1-beta
5. It will then create a zip of the plugin using composer archive
6. Finally this will be uploaded to the GitHub tag

moonmeister
moonmeister previously approved these changes Jun 25, 2025
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trusting your implementation and just looking for major things

@moonmeister moonmeister dismissed their stale review June 25, 2025 18:23

meant to request changes

@colinmurphy colinmurphy requested a review from moonmeister June 25, 2025 18:33
@colinmurphy colinmurphy requested review from ahuseyn and theodesp June 26, 2025 09:56
@colinmurphy colinmurphy enabled auto-merge June 26, 2025 10:03
@colinmurphy colinmurphy added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit d4943d7 Jun 26, 2025
2 of 4 checks passed
@colinmurphy colinmurphy deleted the chore-setup-release-workflow-iteration-1 branch June 26, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants