-
Notifications
You must be signed in to change notification settings - Fork 2
docs: add explanation about GET Vs POST queries #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@theodesp LGTM 🚀 Should we include anything about caching too. Would there be a reason why someone might use GET over POST (or visa versa) in relation to caching? |
colinmurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theodesp for adding info about caching.
LGTM 🚀 🚀 🚀
moonmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moonmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Let's add a brief section on [Automatic] Persisted Queries and how APQs solve the issues with GET requests with links out to Apollo docs or the GraphQL spec (if there is one) where folks can get more info. a link to the how-to could be good too.
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
|
Checkout b112af0. You reverted a bunch of changes. and the URL to the endpoints doc was a fake; you still need to figure out the correct one. |
Co-authored-by: Alex Moon <[email protected]>
colinmurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
#53