Skip to content

Conversation

@theodesp
Copy link
Member

@theodesp theodesp commented Mar 12, 2025

#53

@theodesp theodesp requested a review from a team as a code owner March 12, 2025 13:22
@colinmurphy
Copy link
Member

@theodesp LGTM 🚀

Should we include anything about caching too. Would there be a reason why someone might use GET over POST (or visa versa) in relation to caching?

colinmurphy
colinmurphy previously approved these changes Mar 12, 2025
colinmurphy
colinmurphy previously approved these changes Mar 13, 2025
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theodesp for adding info about caching.

LGTM 🚀 🚀 🚀

Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed great info, but it doesn't satisfy #52. This satisfies #53. Let's add this article under the appropriate title but also do #52.

@theodesp
Copy link
Member Author

This is indeed great info, but it doesn't satisfy #52. This satisfies #53. Let's add this article under the appropriate title but also do #52.

Makes sense. I will update the title and provide anotehr explanation document for the queries.

@theodesp theodesp changed the title docs: add explanation about which url to use when fetching data docs: add explanation about GET Vs POST queries Mar 18, 2025
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Let's add a brief section on [Automatic] Persisted Queries and how APQs solve the issues with GET requests with links out to Apollo docs or the GraphQL spec (if there is one) where folks can get more info. a link to the how-to could be good too.

@theodesp theodesp requested a review from moonmeister March 19, 2025 10:28
@moonmeister
Copy link
Member

@theodesp something weird happened this is the doc from #101

@moonmeister
Copy link
Member

Checkout b112af0. You reverted a bunch of changes. and the URL to the endpoints doc was a fake; you still need to figure out the correct one.

@moonmeister moonmeister enabled auto-merge March 20, 2025 23:28
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@moonmeister moonmeister added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit fdb2aca Mar 24, 2025
1 check passed
@moonmeister moonmeister deleted the explanation-what-url-queries-to-use branch March 24, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants