-
Notifications
You must be signed in to change notification settings - Fork 39
Add PHP 7.4 Support #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shawnhooper
wants to merge
12
commits into
wpengine:master
Choose a base branch
from
shawnhooper:feature/php74
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add PHP 7.4 Support #251
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
573af1d
Version bumping
b576ee0
Add PHP 7.4 to the UI
b3c01e1
Updated stats and readme for 7.4
1a0012c
Add travis tests for PHP 7.4 environments
e4104bf
Updated composer dependency versions
5f10262
Adding my name to the contributors list
416e53e
PHP 7.4 with WP 4.5 not supported, remove test
cccfdd3
Temporarily use 7.4snapshot, as Travis doesn't have 7.4 installed yet…
ea07ebe
Switching to official PHP 7.4 support
b033e3a
Removed 7.4snapshot references. Updated 7.4 w/ Multisite to use WP 5.3
437d42f
Update PHP CodeSniffer to 3.5.0, phpcodesniffer-composer-installer to…
0d35c53
Updated composer.lock
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
# PHP Compatibility Checker <a href="https://travis-ci.org/wpengine/phpcompat"><img src="https://travis-ci.org/wpengine/phpcompat.svg?branch=master"></a> | ||
**Contributors:** [wpengine](https://profiles.wordpress.org/wpengine), [octalmage](https://profiles.wordpress.org/octalmage), [stevenkword](https://profiles.wordpress.org/stevenkword), [Taylor4484](https://profiles.wordpress.org/Taylor4484), [pross](https://profiles.wordpress.org/pross), [jcross](https://profiles.wordpress.org/jcross) | ||
**Contributors:** [wpengine](https://profiles.wordpress.org/wpengine), [octalmage](https://profiles.wordpress.org/octalmage), [stevenkword](https://profiles.wordpress.org/stevenkword), [Taylor4484](https://profiles.wordpress.org/Taylor4484), [pross](https://profiles.wordpress.org/pross), [jcross](https://profiles.wordpress.org/jcross), [shooper](https://profiles.wordpress.org/shooper) | ||
**Tags:** php 7, php 5.5, php, version, compatibility, checker, wp engine, wpe, wpengine | ||
**Requires at least:** 3.5 | ||
**Tested up to:** 5.2.2 | ||
**Stable tag:** 1.5.0 | ||
**Tested up to:** 5.3.0 | ||
**Stable tag:** 1.6.0 | ||
**License:** GPLv2 or later | ||
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html | ||
|
||
|
@@ -21,11 +21,11 @@ This plugin will lint theme and plugin code inside your WordPress file system an | |
|
||
**This plugin relies on WP-Cron to scan files in the background. The scan will get stuck if the site's WP-Cron isn't running correctly. Please see the [FAQ](https://wordpress.org/plugins/php-compatibility-checker/faq/) for more information.** | ||
|
||
### Update to PHP 7.3 ### | ||
* Use this plugin to check your site for compatibility up to PHP 7.3! | ||
* As of [July 2019](https://wordpress.org/about/stats/), 20.1% of WordPress websites run a PHP version older than PHP 5.6. | ||
### Update to PHP 7.4 ### | ||
* Use this plugin to check your site for compatibility up to PHP 7.4! | ||
* As of [November 2019](https://wordpress.org/about/stats/), 12.9% of WordPress websites run a PHP version older than PHP 5.6. | ||
* These versions of PHP have been [deprecated and unsupported](https://secure.php.net/supported-versions.php) for over 2 years. | ||
* Only 54.1% of WordPress websites run PHP 7, the current main version of PHP. | ||
* Only 63.1% of WordPress websites run PHP 7, the current main version of PHP. | ||
|
||
|
||
### Disclaimer ### | ||
|
@@ -64,7 +64,7 @@ PHP Compatibility Checker includes WP-CLI command support: | |
- active | ||
- all | ||
|
||
Example: `wp phpcompat 7.2 --scan=active` | ||
Example: `wp phpcompat 7.4 --scan=active` | ||
|
||
|
||
## Frequently Asked Questions ## | ||
|
@@ -117,6 +117,9 @@ To disclose security issues for this plugin please email [email protected] | |
|
||
|
||
## Changelog ## | ||
### 1.6.0 ### | ||
- Added support for PHP 7.4 compatibility checks | ||
|
||
### 1.5.0 ### | ||
- Added support for PHP 7.3 compatibility checks | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
=== PHP Compatibility Checker === | ||
Contributors: wpengine, octalmage, stevenkword, Taylor4484, pross, jcross | ||
Contributors: wpengine, octalmage, stevenkword, Taylor4484, pross, jcross, shooper | ||
Tags: php 7, php 5.5, php, version, compatibility, checker, wp engine, wpe, wpengine | ||
Requires at least: 3.5 | ||
Tested up to: 5.2.2 | ||
Stable tag: 1.5.0 | ||
Tested up to: 5.3.0 | ||
Stable tag: 1.6.0 | ||
License: GPLv2 or later | ||
License URI: http://www.gnu.org/licenses/gpl-2.0.html | ||
|
||
|
@@ -21,11 +21,11 @@ This plugin will lint theme and plugin code inside your WordPress file system an | |
|
||
**This plugin relies on WP-Cron to scan files in the background. The scan will get stuck if the site's WP-Cron isn't running correctly. Please see the [FAQ](https://wordpress.org/plugins/php-compatibility-checker/faq/) for more information.** | ||
|
||
= Update to PHP 7.3 = | ||
* Use this plugin to check your site for compatibility up to PHP 7.3! | ||
* As of [July 2019](https://wordpress.org/about/stats/), 20.1% of WordPress websites run a PHP version older than PHP 5.6. | ||
= Update to PHP 7.4 = | ||
* Use this plugin to check your site for compatibility up to PHP 7.4! | ||
* As of [November 2019](https://wordpress.org/about/stats/), 12.9% of WordPress websites run a PHP version older than PHP 5.6. | ||
* These versions of PHP have been [deprecated and unsupported](https://secure.php.net/supported-versions.php) for over 2 years. | ||
* Only 54.1% of WordPress websites run PHP 7, the current main version of PHP. | ||
* Only 63.1% of WordPress websites run PHP 7, the current main version of PHP. | ||
|
||
|
||
= Disclaimer = | ||
|
@@ -64,7 +64,7 @@ PHP Compatibility Checker includes WP-CLI command support: | |
- active | ||
- all | ||
` | ||
Example: `wp phpcompat 7.2 --scan=active` | ||
Example: `wp phpcompat 7.4 --scan=active` | ||
|
||
|
||
== Frequently Asked Questions == | ||
|
@@ -113,6 +113,9 @@ To disclose security issues for this plugin please email [email protected] | |
2. Compatibility results screen | ||
|
||
== Changelog == | ||
= 1.6.0 = | ||
- Added support for PHP 7.4 compatibility checks | ||
|
||
= 1.5.0 = | ||
- Added support for PHP 7.3 compatibility checks | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a few more references to the snapshot version in the yaml and also the version tested against is 5.2 which is not php 7.4 compatible. We may need to use 5.3 as our target version or CI will fail and not allow us to merge/publish this release. There are two other references to the 7.4 snapshot and 5.2 WordPress.