-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Add support for CoreNavigation blocks #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
22b2972
feat: Add support for CoreNavigation blocks
theodesp de9aa10
Chore: phpstan fix
theodesp 9b4e9b8
Chore: phpcs fix
theodesp 8524235
Refactor: move logic into ContentBlocksResolver
theodesp 6acd73b
chore: phpcs fix
theodesp 92ec786
chore: wp coding standards fix
theodesp 98ec644
Update thirty-ducks-check.md
theodesp 4f0779a
Update includes/Data/ContentBlocksResolver.php
theodesp 3c7e509
chore: phpcs fix
theodesp 3bbe3e4
chore: update version to minor
theodesp 550aaf4
refactor: cast ref value to int
theodesp 61b1ccf
chore: revert coercion check
theodesp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| --- | ||
| "@wpengine/wp-graphql-content-blocks": minor | ||
| --- | ||
|
|
||
| Adds support for resolving and returning navigation items within the CoreNavigation innerBlocks for WPGraphQL Content Blocks. | ||
|
|
||
| ```graphql | ||
| { | ||
| posts { | ||
| nodes { | ||
| editorBlocks { | ||
| ... on CoreNavigation { | ||
| type | ||
| name | ||
| innerBlocks { | ||
| type | ||
| name | ||
| } | ||
| attributes { | ||
| ref | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
| ```json | ||
| { | ||
| "data": { | ||
| "posts": { | ||
| "nodes": [ | ||
| { | ||
| "editorBlocks": [ | ||
| { | ||
| "type": "CoreNavigation", | ||
| "name": "core/navigation", | ||
| "innerBlocks": [ | ||
| { | ||
| "type": "CorePageList", | ||
| "name": "core/page-list" | ||
| }, | ||
| { | ||
| "type": "CoreNavigationLink", | ||
| "name": "core/navigation-link" | ||
| } | ||
| ], | ||
| "attributes": { | ||
| "ref": 31 | ||
| } | ||
| }, | ||
| ] | ||
| }, | ||
| { | ||
| "editorBlocks": [ | ||
| {} | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.