Use processstarter for launching tools#790
Conversation
sciencewhiz
force-pushed
the
processstarter
branch
from
fa247c6 to
e676edd
Compare
| cppTools.add(new WPICppTool(project, "wpical", wpi.getVersions().getwpicalToolVersion(), | ||
| "edu.wpi.first.tools:wpical", toolsFolder)); | ||
|
|
||
| cppTools.add(new WPICppTool(project, "processstarter", wpi.getVersions().getprocessstarterToolVersion(), |
There was a problem hiding this comment.
Fix formatting, its not indented.
There was a problem hiding this comment.
I think that's an artifact of the github view. Although the next line was indented too much, so I fixed that.
There was a problem hiding this comment.
Nevermind, it wasn't supposed to be in that conditional. Fixed.
build.gradle
Outdated
| testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine") | ||
| testImplementation gradleTestKit() | ||
|
|
||
| processstarterDownload 'edu.wpi.first.tools:processstarter:+:windowsx86-64@zip' |
There was a problem hiding this comment.
Lock the versions used here against updateVersions.
Also, I'm curious how this actually works, as we don't have the wpilib maven repo as a repository.
There was a problem hiding this comment.
I adapted that from this: https://discuss.gradle.org/t/how-to-use-gradle-to-download-artifacts-in-a-script/19228
There was a problem hiding this comment.
I figured out where the repository came from. Its in versionupdates.gradle. I was just confused how it was actually finding an update.
So yeah just fix this to have a fixed version updated from the updateVersions task.
There was a problem hiding this comment.
I was a little worried about rewriting build.gradle, but it seems to work
3 participants
No description provided.