Add all discovered modules from the classpath to compile tasks#792
Open
SamCarlberg wants to merge 5 commits intowpilibsuite:2027from
Open
Add all discovered modules from the classpath to compile tasks#792SamCarlberg wants to merge 5 commits intowpilibsuite:2027from
SamCarlberg wants to merge 5 commits intowpilibsuite:2027from
Conversation
Allows user programs to use `import module` statements without needing to write `module-info,java` files (and keep them up to date as they add vendor libraries)
Member
Author
|
Here's an example of the debug output with modularized versions of WPILib, EJML, and OpenCV: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows user programs to use
import modulestatements without needing to writemodule-info.javafiles (and keep them up to date as they add vendor libraries)See wpilibsuite/allwpilib#7424
Note that CI checks will fail until EJML is modularized. It currently splits packages across multiple JARs, which is disallowed by the Java module system.