-
Notifications
You must be signed in to change notification settings - Fork 687
Description
Is your feature request related to a problem? Please describe.
ProfiledPIDController groups a TrapezoidProfile and PIDController together. This prevents customizing the profile type or easily inserting a feedforward. Motion planning, feedforward, and feedback should ideally be kept separate for this reason.
Describe the solution you'd like
We should just remove ProfiledPIDController and let users do the plumbing themselves. ProfiledPIDController doesn't save any typing for non-continuous profiles, it's less flexible, and it hides plumbing the user needs to know about to effectively troubleshoot it.
Describe alternatives you've considered
We could offer a separate profiled controller type for each motion profile we have, but we're trying to get away from leaky black box abstractions like ProfiledPIDController and RamseteCommand.