Skip to content

Add C++ Commands Ownership page #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add C++ Commands Ownership page #2459

wants to merge 1 commit into from

Conversation

Starlight220
Copy link
Member

Fixes #2438

@sciencewhiz
Copy link
Collaborator

This should either be merged into A Technical Discussion on C++ Commands or the outdated, duplicate information from that article should be removed in favor of this article

@Starlight220
Copy link
Member Author

I'm not sure I agree. Each article serves a different purpose: this one is information that teams need to know, the other is historical context/rationale.
To add notes at the top linking to each other?

@sciencewhiz
Copy link
Collaborator

Are you telling me that the ownership model section of that document is still correct and isn't duplicative of this new article?

@Starlight220
Copy link
Member Author

Fair. The old article does have some outdated or duplicate info.

@sciencewhiz
Copy link
Collaborator

@Starlight220 are you planning to update the old article?

@Starlight220
Copy link
Member Author

Yeah, I just don't really have time atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document differences between CommandPtr (owned) and Command* (non-owned)
2 participants
@Starlight220 @sciencewhiz