Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions external_samples/color_range_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ def get_part_number(self) -> str:
return "REV-31-1557"
def get_url(self) -> str:
return "https://www.revrobotics.com/rev-31-1557"
def get_version(self) -> tuple[int, int, str]:
return (1, 0, "")
def get_version(self) -> tuple[int, int, int]:
return (1, 0, 0)
def stop(self) -> None:
# send stop command to sensor
pass
Expand Down
9 changes: 4 additions & 5 deletions external_samples/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,11 @@ def get_part_number(self) -> str:
@abstractmethod
def get_url(self) -> str:
pass
# This is the version of the software (returned as a (major, minor, revision) tuple where
# major and minor are positive integers
# revision can be an empty string or specify small changes that are less than a
# minor revision
# This is the version of the software (returned as a (major, minor, patch) tuple where
# major, minor and patch are all positive integers
# This MUST follow semantic versioning as described here: https://semver.org/
@abstractmethod
def get_version(self) -> tuple[int, int, str]:
def get_version(self) -> tuple[int, int, int]:
pass

# This stops all movement (if any) for the component
Expand Down
4 changes: 2 additions & 2 deletions external_samples/rev_touch_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def get_part_number(self) -> str:
return "REV-31-1425"
def get_url(self) -> str:
return "https://www.revrobotics.com/rev-31-1425/"
def get_version(self) -> tuple[int, int, str]:
return (1, 0, "")
def get_version(self) -> tuple[int, int, int]:
return (1, 0, 0)
def stop(self) -> None:
pass
def reset(self) -> None:
Expand Down
4 changes: 2 additions & 2 deletions external_samples/servo.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def get_part_number(self) -> str:
return "REV-41-1097"
def get_url(self) -> str:
return "https://www.revrobotics.com/rev-41-1097/"
def get_version(self) -> tuple[int, int, str]:
return (1, 0, "")
def get_version(self) -> tuple[int, int, int]:
return (1, 0, 0)
def stop(self) -> None:
# De-energize servo port
pass
Expand Down
4 changes: 2 additions & 2 deletions external_samples/smart_motor.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ def get_part_number(self) -> str:
return "REV-xx-xxxx"
def get_url(self) -> str:
return "https://www.revrobotics.com/rev-xx-xxxx"
def get_version(self) -> tuple[int, int, str]:
return (1, 0, "")
def get_version(self) -> tuple[int, int, int]:
return (1, 0, 0)
def stop(self) -> None:
# send stop command to motor
pass
Expand Down
4 changes: 2 additions & 2 deletions external_samples/sparkfun_led_stick.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ def get_part_number(self) -> str:
def get_url(self) -> str:
return "https://www.sparkfun.com/sparkfun-qwiic-led-stick-apa102c.html"

def get_version(self) -> tuple[int, int, str]:
return (1, 0, "")
def get_version(self) -> tuple[int, int, int]:
return (1, 0, 0)

def stop(self) -> None:
self.turn_all_off()
Expand Down