-
Notifications
You must be signed in to change notification settings - Fork 8
Generate blocks for calling component functions #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…class. Changed component class names to be consistent with the external_samples python files. Updated generated json files. Added function addInstanceComponentBlocks to mrc_call_python_function.ts to generate component function blocks. Updated function getBlocks in blocks_components.ts to use addInstanceComponentBlocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are events in the external_samples_data.json file?
Most of these are minor, but I think there is a bug in the mrc_call_python_function
external_samples_data.json contains the data for python instance methods. The ones related to events are
|
Added TODO where the component name dropdown is created in mrc_call_python_function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added external_samples/spark_mini.py that wraps the wpilib.SparkMini class.
Changed component class names to be consistent with the external_samples python files.
Updated generated json files.
Added function addInstanceComponentBlocks to mrc_call_python_function.ts to generate component function blocks. Updated function getBlocks in blocks_components.ts to use addInstanceComponentBlocks.