Skip to content

Conversation

lizlooney
Copy link
Collaborator

No description provided.

@lizlooney lizlooney requested a review from alan412 July 3, 2025 23:37
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, a wholesale search and replace changes things that should still be project (referring to the robot, mechanisms, and all opmodes.). I didn't go through and mark all of them as it might be easier to abandon this PR and just change the ones that apply to the module that is now the robot

/**
* Main application component that manages the Blockly interface, code generation,
* project management, and user interface layout.
* robot management, and user interface layout.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should still be project

/** Creates tab items from project data. */
const createTabItemsFromProject = (projectData: commonStorage.Project): Tabs.TabItem[] => {
/** Creates tab items from robot data. */
const createTabItemsFromRobot = (robotData: commonStorage.Robot): Tabs.TabItem[] => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be project

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and projectData - throughout this method

alertErrorMessage={alertErrorMessage}
setAlertErrorMessage={setAlertErrorMessage}
project={project}
robot={robot}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still be project

project={project}
setProject={setProject}
robot={robot}
setRobot={setRobot}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still be project

const [generatedCode, setGeneratedCode] = React.useState<string>('');
const [toolboxSettingsModalIsOpen, setToolboxSettingsModalIsOpen] = React.useState(false);
const [project, setProject] = React.useState<commonStorage.Project | null>(null);
const [robot, setRobot] = React.useState<commonStorage.Robot | null>(null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should still be project

private moduleContent: string = '';
private projectContent: string = '';
private currentModulePath: string = '';
private robotPath: string = '';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably still be projectPath


return [
getItem(t('Project'), 'project', <FolderOutlined />, [
getItem(t('Robot'), 'robot', <FolderOutlined />, [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be project

@lizlooney lizlooney closed this Jul 4, 2025
@lizlooney lizlooney deleted the pr_project_to_robot branch July 4, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants