-
Notifications
You must be signed in to change notification settings - Fork 8
Changed project to robot. #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, a wholesale search and replace changes things that should still be project (referring to the robot, mechanisms, and all opmodes.). I didn't go through and mark all of them as it might be easier to abandon this PR and just change the ones that apply to the module that is now the robot
/** | ||
* Main application component that manages the Blockly interface, code generation, | ||
* project management, and user interface layout. | ||
* robot management, and user interface layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should still be project
/** Creates tab items from project data. */ | ||
const createTabItemsFromProject = (projectData: commonStorage.Project): Tabs.TabItem[] => { | ||
/** Creates tab items from robot data. */ | ||
const createTabItemsFromRobot = (robotData: commonStorage.Robot): Tabs.TabItem[] => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and projectData - throughout this method
alertErrorMessage={alertErrorMessage} | ||
setAlertErrorMessage={setAlertErrorMessage} | ||
project={project} | ||
robot={robot} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should still be project
project={project} | ||
setProject={setProject} | ||
robot={robot} | ||
setRobot={setRobot} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should still be project
const [generatedCode, setGeneratedCode] = React.useState<string>(''); | ||
const [toolboxSettingsModalIsOpen, setToolboxSettingsModalIsOpen] = React.useState(false); | ||
const [project, setProject] = React.useState<commonStorage.Project | null>(null); | ||
const [robot, setRobot] = React.useState<commonStorage.Robot | null>(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should still be project
private moduleContent: string = ''; | ||
private projectContent: string = ''; | ||
private currentModulePath: string = ''; | ||
private robotPath: string = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably still be projectPath
|
||
return [ | ||
getItem(t('Project'), 'project', <FolderOutlined />, [ | ||
getItem(t('Robot'), 'robot', <FolderOutlined />, [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still be project
No description provided.