Skip to content

Fill the Robot -> Methods category #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fill the Robot -> Methods category #157

merged 1 commit into from
Jul 11, 2025

Conversation

lizlooney
Copy link
Collaborator

Update the Robot -> Methods category on the toolbox when the user is editing an opmode.

Removed code that stored "exportedBlocks".

@lizlooney lizlooney requested a review from alan412 July 10, 2025 06:32
alan412
alan412 approved these changes Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably log an issue that changing the parameters on a method in the robot doesn't update the opmodes where it is used.

@alan412 alan412 merged commit 1374bde into wpilibsuite:main Jul 11, 2025
1 check passed
@lizlooney lizlooney deleted the pr_robot_methods branch July 11, 2025 02:21
@lizlooney
Copy link
Collaborator Author

LGTM. We should probably log an issue that changing the parameters on a method in the robot doesn't update the opmodes where it is used.

Issue #72 covers that.

@lizlooney lizlooney mentioned this pull request Jul 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan412 alan412 alan412 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lizlooney @alan412