Combine internationalization #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizlooney
requested changes
Jul 11, 2025
| @@ -0,0 +1,59 @@ | |||
| { | |||
There was a problem hiding this comment.
Did you write these strings? Do you speak Spanish?
There was a problem hiding this comment.
I had Copilot (Claude 4 Sonnet) translate for me.
There was a problem hiding this comment.
Can you add a comment that says we should have a native Spanish speaker check these?
There was a problem hiding this comment.
Since JSON doesn't allow comments, I put a key:value pair at the top that was "TODO" and a note. How is that?
lizlooney
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually puts two languages in the menu system and makes it work across React and Blockly. I haven't combed through the code yet looking for all strings and changing them.