Pr test print #161
Merged
Pr test print #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(annotations are something different in python)
lizlooney
reviewed
Jul 12, 2025
| * toolbox. | ||
| */ | ||
| export const mechanism_class_blocks: toolboxItems.Block[] = [ | ||
| { |
There was a problem hiding this comment.
Why are these hardcoded? Can't we generate these blocks from json?
There was a problem hiding this comment.
I just kept them like they were before. I don’t see any reason they can’t be json
| export const robot_class_blocks: toolboxItems.Block[] = [ | ||
| // TODO(lizlooney): Add one mrc_class_method_def blocks for each method in ther Robot class. | ||
| ]; | ||
| { |
There was a problem hiding this comment.
Why are these hardcoded? Can't we generate these blocks from json?
There was a problem hiding this comment.
Made them the same as the ones for opmode and mechanism. I don’t see a reason they couldn’t be json.
lizlooney
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all code to run our blockly code!!!
(I apologize for doing some other cleanup at the same time)
Changes to base classes as well as our code generator.
This only tests opmode and robot classes. It does not test mechanism generation.