Added python tool that generates json #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use mrc_call_python_function for the print block.
alan412
approved these changes
Jul 13, 2025
There was a problem hiding this comment.
I think items.ts needs to have contents as not optional in the Category class. If contents aren't passed in, then the contents array should be set to [] instead of being allowed to be undefined. While that isn't part of this PR, this PR causes a typescript error in the test_category file.
That can either be part of this PR, or I can do it in a general cleanup PR that I am planning.
I did find one minor problem, but it doesn't keep me from approving.
| export function getCategory(): toolboxItems.Category { | ||
| const contents: toolboxItems.ContentsType[] = []; | ||
|
|
||
| const printFunction: FunctionData = { |
There was a problem hiding this comment.
FunctionData needs to be imported
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added python tool that generates json
Added support for built-in methods (like print) to mrc_call_python_function.
Use mrc_call_python_function for the print block.