Store a version number. #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if we decide to upgrade when the project is loaded, it's easier to store the version number in every module.
alan412
reviewed
Jul 18, 2025
There was a problem hiding this comment.
Let's talk about this on Monday. I thought we had said just a project number. Also, I am beginning to wonder if we should just be saving our files as json rather than json as a comment in the python. I need to be reminded of the benefit of saving the python in the file.
|
|
||
| // Types, constants, and functions related to modules, regardless of where the modules are stored. | ||
|
|
||
| export const CURRENT_VERSION = '0.1'; |
There was a problem hiding this comment.
I wonder if we should use the blockly version instead of having a version specific for the file format
| methodsContent: string, | ||
| componentsContent: string): string { | ||
| componentsContent: string, | ||
| optVersionContent?: string): string { |
There was a problem hiding this comment.
Not sure we want this optional. When one is uploaded without it, we are giving it a default value.
…face into pr_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a version number in all modules.
Even if we decide to upgrade when the project is loaded, it's easier to store the version number in every module.