Skip to content

Update parameters in a call method block in an opmode if the method definition in the robot was changed. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Update parameters in a call method block in an opmode if the method definition in the robot was changed. #176

merged 1 commit into from
Jul 21, 2025

Conversation

@lizlooney
Copy link
Collaborator

In mrc_call_python_function.ts, modified the onLoad method to update the parameters.

Fixes #72

@lizlooney lizlooney requested a review from alan412 July 19, 2025 05:07
alan412
alan412 approved these changes Jul 21, 2025
View reviewed changes
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first pass here and avoids the rabbit hole of dealing with rearranged parameters (which we might want to do later but probably not MVP.)

@alan412 alan412 merged commit ef87007 into wpilibsuite:main Jul 21, 2025
1 check passed
@lizlooney lizlooney deleted the pr_issue_72 branch July 21, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alan412 alan412 alan412 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update mrc_call_python_function blocks in other modules if a mrc_class_method_def block is changed

2 participants

@lizlooney @alan412