Make RobotBase.__init__ call self.define_hardware() #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init__. Modified mrc_mechanism_component_holder pythonFromBlock to determine the module type by calling generator.getModuleType() instead of checking for the presence of the mechanisms input. Modified ExtendedPythonGenerator.generateInitStatements to not generate the call so self.define_hardware() if the module type is robot. Modified ExtendedPythonGenerator.finish to generate the __init__ method before other methods.
alan412
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add define_hardware method to RobotBase and call it from RobotBase.init.
Modified mrc_mechanism_component_holder pythonFromBlock to determine the module type by calling generator.getModuleType() instead of checking for the presence of the mechanisms input.
Modified ExtendedPythonGenerator.generateInitStatements to not generate the call so self.define_hardware() if the module type is robot.
Modified ExtendedPythonGenerator.finish to generate the init method before other methods.