Added components for ExpansionHubServo and ExpansionHubMotor. #188
Conversation
Added start and update methods to components. Added code to run_opmode to print stacktrace if an error occurs.
| def isHubConnected(self) -> bool: | ||
| return self.expansion_hub_motor.isHubConnected() | ||
|
|
||
| def getEncoder(self) -> float: |
There was a problem hiding this comment.
I thought encoder ticks were int instead of float
There was a problem hiding this comment.
It's float in the class from Thad. See
| def getEncoderVelocity(self) -> float: | ||
| return self.expansion_hub_motor.getEncoderVelocity() | ||
|
|
||
| def setReversed(self, reversed: bool): |
There was a problem hiding this comment.
Do we need a getReversed as well?
There was a problem hiding this comment.
Probably, but it will need to be added here
| def resetEncoder(self): | ||
| self.expansion_hub_motor.resetEncoder() | ||
|
|
||
| def getVelocityPidConstants(self) -> expansion_hub.ExpansionHubPidConstants: |
There was a problem hiding this comment.
Maybe. It will need to be added here as well. We should talk to Thad.
| def getVelocityPidConstants(self) -> expansion_hub.ExpansionHubPidConstants: | ||
| return self.expansion_hub_motor.getVelocityPidConstants() | ||
|
|
||
| def getPositionPidConstants(self) -> expansion_hub.ExpansionHubPidConstants: |
There was a problem hiding this comment.
Maybe. It will need to be added here as well. We should talk to Thad.
| def set(self, value: float): | ||
| self.expansion_hub_servo.set(value) | ||
|
|
||
| def setAngle(self, degrees: float): |
There was a problem hiding this comment.
If this takes degrees, should it be setAngleDegrees?
There was a problem hiding this comment.
It's just setAngle here. We can talk about changing it with Thad and others.
…face into pr_expansion_hub_components
Removed empty start, update, and stop methods from component subclasses.
2 participants
Added components for ExpansionHubServo and ExpansionHubMotor.
Added start and update methods to components.
Added code to run_opmode to print stacktrace if an error occurs.