Skip to content

Conversation

lizlooney
Copy link
Collaborator

Save modules with names like ProjectName.ClassName.json.
Save modules with multi-line formatted json.

Removed moduleName field from Module (and Robot, Mechanism, and OpMode). Removed userVisibleName from Project.

Renamed ModuleNameComponent.tsx to ClassNameComponent.tsx.

In Menu.tsx, added handleDownload and handleUpload. I didn't add the actual UI element (menu or button, etc) to trigger the handlers.

Save modules with multi-line formatted json.

Removed moduleName field from Module (and Robot, Mechanism, and OpMode).
Removed userVisibleName from Project.

Renamed ModuleNameComponent.tsx to ClassNameComponent.tsx.

In Menu.tsx, added handleDownload and handleUpload. I didn't add the actual UI element (menu or button, etc) to trigger the handlers.
@lizlooney lizlooney requested a review from alan412 August 7, 2025 07:28
@lizlooney
Copy link
Collaborator Author

I'm sorry this is so big!

Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates a number of typescript errors. These are the errors and should be fixed before we merge.

Screenshot 2025-08-07 at 8 05 06 AM

@lizlooney
Copy link
Collaborator Author

I fixed all the errors and also made it easier to show a temporary upload download UI for testing purposees.

@alan412
Copy link
Collaborator

alan412 commented Aug 8, 2025

Much better, but I still get one error...

Screenshot 2025-08-07 at 9 25 30 PM

Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan412 alan412 merged commit acbfc1f into wpilibsuite:main Aug 8, 2025
1 check passed
@lizlooney lizlooney deleted the pr_json_file_names branch August 8, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants