Refine Storage interface #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added listModules and fetchModuleDataModifiedMillis functions to Storage interface.
Added modulePathFilter parameter to listModules. Removed renameProject and copyProject. Removed moduleType parameter from deleteModule. In client_side_storage: Updated implementation of Storage interface (see above). Removed _renameOrCopyProject. In names: Added makeModulePathPrefix. In project: Updated renameProject and copyProject functions. Added renameOrCopyProject function.
Removed renameModule, copyModule, and _renameOrCopyModule from client_side_storage In project.ts, updated implementation of renameModuleInProject and copyModuleInProject. Added renameOrCopyModule function.
Removed deleteProject from client_side_storage. In project.ts, updated implementation of deleteProject.
Removed downloadProject from client_side_storage. In project.ts, replaced produceDownloadProjectBlob with downloadProject. In Menu.tsx, call storageProject.downloadProject instead of storage.downloadProject.
Removed uploadProject from client_side_storage. In project.ts: Added uploadProject function. Modified processUploadedBlob to return just classNameToModuleContentText. Moved code from processUploadedModule to processUploadedBlob. In Menu.tsx, call storageProject.uploadProject instead of storage.uploadProject.
alan412
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
I am approving this, because I think it takes us in the right direction. However, I think we will want a listProjects that doesn't read all of the modules. That way it will return quickly. I think of it like reading a directory. You want to return the subdirectory names without parsing all of the files in each subdirectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed functions related to projects from the Storage interface. Added code to project.ts to handle project stuff.
This will make implementing the server side storage easier.