Skip to content

Share VariableKind enum for get and set python variable blocks #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Share VariableKind enum for get and set python variable blocks #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/blocks/mrc_get_python_variable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import * as toolboxItems from '../toolbox/items';

export const BLOCK_NAME = 'mrc_get_python_variable';

enum VariableKind {
export enum VariableKind {
MODULE = 'module',
CLASS = 'class',
INSTANCE = 'instance',
Expand Down
9 changes: 1 addition & 8 deletions src/blocks/mrc_set_python_variable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import * as Blockly from 'blockly';
import { Order } from 'blockly/python';

import { VariableKind } from './mrc_get_python_variable';
import { getAllowedTypesForSetCheck } from './utils/python';
import * as variable from './utils/variable';
import { ExtendedPythonGenerator } from '../editor/extended_python_generator';
Expand All @@ -36,14 +37,6 @@ import * as toolboxItems from '../toolbox/items';

export const BLOCK_NAME = 'mrc_set_python_variable';

// TODO(lizlooney): Consider combining VariableKind here with VariableKind in
// mrc_get_python_variable.ts. They are identical.
enum VariableKind {
MODULE = 'module',
CLASS = 'class',
INSTANCE = 'instance',
}

const FIELD_MODULE_OR_CLASS_NAME = 'MODULE_OR_CLASS';
const FIELD_VARIABLE_NAME = 'VAR';

Expand Down