All components take a single port #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compare port_type with PortType.BASE_COMPOUND, use .value to get the numeric value.
Added type hints for function returns.
Modified get_type to just return self.type.
In component.py:
Changed port.get_type to port.get_type().
In mrc_port.ts, in pythonFromBlock:
Changed _generator to generator.
Added generator.addImport('port');
Changed Port to port.Port in generated python code.
Changed PortType to port.PortType in generated python code.
Changed MOTOR_PORT to EXPANSION_HUB_MOTOR_PORT.
Changed SERVO_PORT to EXPANSION_HUB_SERVO_PORT.
Updated external_samples_data.json.
lizlooney
requested changes
Aug 31, 2025
| from enum import Enum | ||
| from typing import Self | ||
|
|
||
| class PortType(Enum): |
Collaborator
There was a problem hiding this comment.
Can you add a class comment that shows examples of how to use PortType?
Collaborator
Author
There was a problem hiding this comment.
I am happy to write a comment here, but I couldn't come up with anything about how to use it that didn't seem like "this is the type of port". Suggestions?
Make it work on systemcore
lizlooney
reviewed
Aug 31, 2025
lizlooney
requested changes
Sep 4, 2025
Collaborator
lizlooney
left a comment
lizlooney
left a comment
There was a problem hiding this comment.
Oops. I approved this too soon. I found some problems when running it on systemcore.
…ate json. Regenerated json.
Collaborator
Changed 'unknown:' to 'unknown'.
Fix mrc_port python generator
lizlooney
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, all components take a single "port"
However, this "port" can be a compound type. For example a motor port on an expansion hub is a singular port, but it has two parts to it.
The advantage to this is that we'll be able to know if the user is trying to use the same physical port in their code twice.
This was much larger than I thought it would be when I started. I apologize for the size of this and I also apologize that this breaks all saved projects.
There is cleanup that needs to occur (things that aren't used anymore), but I didn't want to do all of that until we agreed this is the direction we want to head.