Make necessary changes to blocks when changing tabs #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidate. Make mrcOnLoad call mrcValidate. In editor.makeCurrent, call the mrcValidate method on all blocks that implement it.
alan412
approved these changes
Sep 19, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
Verified that it works on my system. Had one question but it is minor and doesn't stop approval
src/editor/editor.ts
Outdated
|
|
||
| // Go through all the blocks in the workspace and call their mrcValidate method. | ||
| this.blocklyWorkspace.getAllBlocks().forEach(block => { | ||
| if ('mrcValidate' in block && typeof block.mrcValidate === "function") { |
Collaborator
There was a problem hiding this comment.
Should 'mrcValidate' be a defined constant? Also why is one of these a single quoted string and one a double quoted one?
Changed double quotes to single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In blocks that have an mrcOnLoad method, create a method called mrcValidate. Make mrcOnLoad call mrcValidate.
In editor.makeCurrent, call the mrcValidate method on all blocks that implement it.
Fixes #237