-
Notifications
You must be signed in to change notification settings - Fork 8
Cleaned up AddTab Dialog #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can but I thought that current UI thought is that it is better to show it as empty rather than have students not understand why it is different on different times they bring it up. |
Ok sounds good. What do you think of making the hidden list shorter (less tall) if it is empty? |
That is a good trade-off. I'll do that.
…--Alan
On Sun, Sep 21, 2025 at 3:15 PM Liz Looney ***@***.***> wrote:
*lizlooney* left a comment (wpilibsuite/systemcore-blocks-interface#241)
<#241 (comment)>
This is a big improvement! I just have a couple suggestions.
Can you hide the hidden section if there are no hidden opmodes/mechanism?
I can but I thought that current UI thought is that it is better to show
it as empty rather than have students not understand why it is different on
different times they bring it up.
Ok sounds good. What do you think of making the hidden list shorter (less
tall) if it is empty?
—
Reply to this email directly, view it on GitHub
<#241 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF3Y76UGPT4GRVOINQ3K3D3T32O3AVCNFSM6AAAAACG7CRQF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJWGIYDKMJQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
See what you think of it being smaller now if empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
…face into pr_fix_add_tab
This makes the Add Tab Dialog much much simpler and obvious
Fixes #225