Skip to content

Conversation

alan412
Copy link
Collaborator

@alan412 alan412 commented Sep 19, 2025

This makes the Add Tab Dialog much much simpler and obvious

Fixes #225

@alan412 alan412 requested a review from lizlooney September 19, 2025 13:54
@lizlooney
Copy link
Collaborator

lizlooney commented Sep 21, 2025

This is a big improvement! I just have a couple suggestions.

Can you hide the hidden section if there are no hidden opmodes/mechanism?

Screenshot 2025-09-20 at 9 32 20 PM

@alan412
Copy link
Collaborator Author

alan412 commented Sep 21, 2025

This is a big improvement! I just have a couple suggestions.

Can you hide the hidden section if there are no hidden opmodes/mechanism?

I can but I thought that current UI thought is that it is better to show it as empty rather than have students not understand why it is different on different times they bring it up.

@lizlooney
Copy link
Collaborator

This is a big improvement! I just have a couple suggestions.
Can you hide the hidden section if there are no hidden opmodes/mechanism?

I can but I thought that current UI thought is that it is better to show it as empty rather than have students not understand why it is different on different times they bring it up.

Ok sounds good. What do you think of making the hidden list shorter (less tall) if it is empty?

@alan412
Copy link
Collaborator Author

alan412 commented Sep 21, 2025 via email

@alan412
Copy link
Collaborator Author

alan412 commented Sep 24, 2025

See what you think of it being smaller now if empty

@alan412 alan412 requested a review from lizlooney September 24, 2025 01:33
Copy link
Collaborator

@lizlooney lizlooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alan412 alan412 merged commit 3adb51f into wpilibsuite:main Sep 24, 2025
1 check passed
@alan412 alan412 deleted the pr_fix_add_tab branch September 26, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tab dialog box needs to be reworked
2 participants