Skip to content

Renamed field is_pressed to _is_pressed in rev_touch_sensor.py #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Renamed field is_pressed to _is_pressed in rev_touch_sensor.py #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions external_samples/rev_touch_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
class RevTouchSensor(Component):
def __init__(self, port : Port):
super().__init__(port, PortType.SMART_IO_PORT)
self.is_pressed = None
self._is_pressed = None

def get_manufacturer(self) -> str:
return "REV Robotics"
Expand All @@ -46,23 +46,23 @@ def reset(self) -> None:
pass

def periodic(self) -> None:
old = self.is_pressed
old = self._is_pressed
self._read_hardware()
if old != self.is_pressed:
if self.is_pressed and self.pressed_callback:
if old != self._is_pressed:
if self._is_pressed and self.pressed_callback:
self.pressed_callback()
elif old and self.released_callback:
self.released_callback()

# Component specific methods

def _read_hardware(self):
# here read hardware to get the current value of the sensor and set self.is_pressed
# here read hardware to get the current value of the sensor and set self._is_pressed
pass

def is_pressed(self) -> bool:
'''Returns if the touch sensor is pressed or not'''
return self.is_pressed
return self._is_pressed

# Events
def register_when_pressed(self, callback: EmptyCallable) -> None:
Expand Down