Cleaned up mrc_port.ts #254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made constants for field prefixes. Made constants for visible port types. Removed "export" from type MrcPortType. Renamed fields in PortMixin to being with mrc and not end with _. Removed updateShape_, which is only called from loadExtraState. Removed unnecessary code that removes all existing ports and initializes ports if not set. Moved the remaining code from updateShape_ to loadExtraState. Simplified the code in pythonFromBlock that collects the ports. Generate code for CompoundPort without trailing backslashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made constants for field prefixes.
Made constants for visible port types.
Removed "export" from type MrcPortType.
Renamed fields in PortMixin to being with mrc and not end with _.
Removed updateShape_, which is only called from loadExtraState. Removed unnecessary code that removes all existing ports and initializes ports if not set. Moved the remaining code from updateShape_ to loadExtraState.
Simplified the code in pythonFromBlock that collects the ports.
Generate code for CompoundPort without trailing backslashes.