Skip to content

Conversation

alan412
Copy link
Collaborator

@alan412 alan412 commented Sep 26, 2025

Fixes #235

This saves the list of open tabs as a user setting per project so when they come back to a project they will see the same tabs open.

@alan412 alan412 requested a review from lizlooney September 26, 2025 22:58
Copy link
Collaborator

@lizlooney lizlooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

I just have one question about naming.

const DEFAULT_THEME = 'dark';

/** Helper function to generate project-specific storage key for open tabs. */
const getUserOptionsKey = (projectName: string): string => `user_options_${projectName}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called getUserOptionsKey, but it is for storing open tabs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I am convinced that there will be more project options per user in the future. I just don't know what they are yet....

@alan412 alan412 merged commit 912c007 into wpilibsuite:main Sep 28, 2025
1 check passed
@alan412 alan412 deleted the pr_store_tabs branch September 30, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of open tabs should persist across sessions
2 participants