Prevent detached warning balloon on event block #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to onChangeAfterLoading to handle MOVE events. If the block being moved has a mrcOnMove method, call it. In mrc_event.ts: Added constants INPUT_TITLE, FIELD_PARAM_PREFIX, and WARNING_ID_NOT_IN_HOLDER. Removed call to ChangeFramework.registerCallback. Removed onBlockChanged. Added mrcHasWarning to EventMixin. Added mrcOnLoad so that the block is checked when the block is loaded. Added mrcOnMove so that the block is checked when the block is moved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248
In editor.ts:
Added code to onChangeAfterLoading to handle MOVE events. If the block being moved has a mrcOnMove method, call it.
In mrc_event.ts:
Added constants INPUT_TITLE, FIELD_PARAM_PREFIX, and WARNING_ID_NOT_IN_HOLDER. Removed call to ChangeFramework.registerCallback.
Removed onBlockChanged.
Added mrcHasWarning to EventMixin.
Added mrcOnLoad so that the block is checked when the block is loaded. Added mrcOnMove so that the block is checked when the block is moved.