Update mrc_get_parameter to respond to mrcOnMove and mrcOnAncestorMove #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed type Parameter to interface Parameter and export it. Added method mrcGetParameterNames. In mrc_event.ts: Import Parameter from mrc_class_method_def.ts. Fixed comment for mrcOnMove. In mrc_event_handler.ts: Import Parameter from mrc_class_method_def.ts. Added method mrcGetParameterNames. In mrc_get_parameter.ts: Added constants FIELD_PARAMETER_NAME and WARNING_ID_GET_PARAMETER. Removed parameterType from GET_PARAMETER_BLOCK. Added mrcParameterType and mrcHasWarning to GetParameterMixin. Replaced onBlockChanged with mrcOnMove, mrcOnAncestorMove, and checkBlockPlacement. Updated checkBlockPlacement to call mrcGetParameterNames on the root block if it is a mrc_class_method_def or mrc_event_handler block. In editor.ts: Added code to call mrcOnAncestorMove for all descendants of the block that was moved.
alan412
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mrc_get_parameter to respond to mrcOnMove and mrcOnAncestorMove, instead of using change_framework.