Changed mechanism, component, and event blocks to use functions mrcOnMove for handling events from blockly #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e module becomes the current module.
…if the block is not in the holder. Updated code in mrc_event.ts (which already existed) to be similar.
In mrc_mechanism_component_holder.ts: Removed code that uses change framework. Replaced function setName with method MechanismComponentHolderBlock.setNameOfChildBlock. Replaced function updateToolboxAfterDelay with method MechanismComponentHolderBlock.updateToolboxAfterDelay. Added function mrcDescenantsMayHaveChanged, which calls method MechanismComponentHolderBlock.mrcDescenantsMayHaveChanged. MechanismComponentHolderBlock.mrcDescenantsMayHaveChanged collects the ids of mechanisms, components, private components, and events and if they have changed, calls updateToolboxAfterDelay. Updated mrc_mechanism, mrc_component, and mrc_event to call MechanismComponentHolderBlock.setNameOfChildBlock when they are connected to the holder. Update mrc_mechanism, mrc_component, and mrc_event to call mrcDescendantsMayHaveChanged when they are moved.
…aren't in the holder. If there are more than one of these in a stack and the user drags the whole stack out of the holder, the unplug will unplug the top one from the stack which is alarming. In mrc_mechanism_component_holder: Changed mrcMechanismIds to mrcMechanismBlockIds, mrcComponentIds to mrcComponentBlockIds, mrcPrivateComponentIds to mrcPrivateComponentBlockIds, and mrcEventIds to mrcEventBlockIds. Made them strings, which makes the comparing much more simple. Added mrcOnDescendantDisconnected, which is called when a mechanism, component, or event block is deleted. In editor, added code to handle move event for disconnect and call mrcOnDescendantDisconnect on the root block that the block was disconnected from.
lizlooney
changed the title
…face into pr_blockly_events
Agreed. I'm already working on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed mechanism, component, and event blocks to use functions mrcOnMove for handling events from blockly instead of the change framework.
Renamed mrcValidate to mrcOnModuleCurrent because it is called when the module becomes the current module.
Add warning if a component or mechanism block is moved out of the holder.
Update toolbox if mechanisms, components, or events are moved in to or out of the holder or deleted.
Fixes #232
Fixes #273