Call the steps method after super.loop #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed code from opmode.py that calls the steps method. In mrc_class_method_def.ts: Renamed classSpecific and getClassSpecificForInit to superInitParameters and getSuperInitParameters. In mrc_steps.ts: Added constant STEPS_METHOD_NAME and changed the steps method name to _steps. In python.ts: Added constant PERIODIC_METHOD_NAME. In extended_python_generator.ts: Changed finish method to add the code for calling the steps method to the end of the loop method. Renamed getClassSpecificForInit to getSuperInitParameters.
alan412
requested changes
Nov 12, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
In addition to the other review comment, do we want to warn the user if they don't have a loop or steps in an opmode?
…face into pr_issue_298
…od, show a warning on the opmode details block.
Collaborator
Author
Done. |
alan412
requested changes
Nov 13, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
Mostly looks good. A few minor things.
…face into pr_issue_298
…that needs to be translated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call the steps method after super.loop.
Changed the steps method name to _steps.
Let the user delete the loop method in an OpMode.
Fixes #298